Hopefully fixes Orderedict error #1301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill still work until 3.12
|
Thanks again for all your help and commitment!
Indeed, that's a bummer. As if fighting python and its ecosystem wasn't enough, now CI breaks as well. I cancelled all stuck jobs and retried, the current one gets stuck right when running |
Closed
|
Closing this and will re-submit in parts, as CI still not running, but did run on other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes Orderedict error for py<3.7.2 and py>3.10
Talk about an unstable api!
I added type: ignores to pass mypy for 3.6, and removed the version guard for py<3.10 (typing.OrderedDict gets deprecated in favor or collections.Ordereddict again, but it will still work until 3.12 at least, so can worry about it once 3.6 dropped. Or I guess once 3.7.1 dropped really.
Also added some types that got missed in Symbolic.py
#1300 #1095
Testing on GitHubActions appears to be broken? The last commits all stuck ("Can't find any online and idle self-hosted or hosted runner in the current repository, account/organization that matches the required labels: 'ubuntu-latest'")