ssh: add support for extension negotiation (rfc 8308) #2
Conversation
This is a rebase of the following PR golang#197 with some changes and improvements: - added support for client certificate authentication - removed read loop from server handshake - adapted extInfoMsg to upstream changes Signed-off-by: Nicola Murino <[email protected]>
always add ext-info-s to KEX and send the SSH_MSG_EXT_INFO message if we received ext-info-c from the client Signed-off-by: Nicola Murino <[email protected]>
Signed-off-by: Nicola Murino <[email protected]>
we already know if this is the first key exchange Signed-off-by: Nicola Murino <[email protected]>
we need it for both client and server Signed-off-by: Nicola Murino <[email protected]>
Signed-off-by: Nicola Murino <[email protected]>
both client and server side need to parse this message Signed-off-by: Nicola Murino <[email protected]>
Signed-off-by: Nicola Murino <[email protected]>
|
I will close it for now. We decided to wait for official fix in upstream. |
|
@akosyakov Why the need to wait? I would say this is a blocker to make gitpod-desktop extension GA, we don't know how many users have newer ssh client, without this all users using ubuntu 22.04 which is LTS version and with rsa keys wouldn't be able to connect and the error shown by the ssh client is not really helpful |
|
I think the reasoning was because golang#211 in progress, not something what was approved by authors. I'm not sure about the quality and completeness of the solution. I added to our sync point next monday. |
|
I think we probably can't wait for the official PR golang#211 merge, on the one hand, this PR hasn't had a new commit for 2 months and the last comment was a month ago, no one knows when it will be merged Also the latest beta for macOS has upgraded the ssh-client to openssh 9.0 which means the latest macOS 13.0 will have a ton of people having this problem by the time it's released in the fall, so we may have to merge it ourselves and watch for official movement |
This PR is cherry-pick from golang#211