[theia] add css/htm language features extensions #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
approved these changes
Dec 9, 2020
akosyakov
force-pushed
the
akosyakov/code-highlighting-emmet-2444
branch
2 times, most recently
from
1bcd4f5 to
e6a3726
Compare
|
I struggle to find a good version of css language features extension. All of them is failing with |
|
Can we build our own extension? |
looking how can i work it around in Gitpod Theia, maybe brining support via Monaco back (only for css, html seems to work) |
akosyakov
force-pushed
the
akosyakov/code-highlighting-emmet-2444
branch
6 times, most recently
from
315d2da to
1442aab
Compare
akosyakov
force-pushed
the
akosyakov/code-highlighting-emmet-2444
branch
from
1442aab to
2e3b591
Compare
|
I patched the plugin host process for now to fix completions compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
@theia/monacodoes not provide smartness for css/html by default anymore: eclipse-theia/theia#7972 so we should consume them as VS Code extensions.How to test
Check html/css language smartness: http://akosyakov-code-highlighting-emmet-2444.staging.gitpod-dev.com/#https://github.com/vuejs/vue-router