-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[image-builder-bob] update buildkit version #19383
Conversation
Related to #19382 ...which hit a limit due to lets encrypt rate limiting. Good luck, new branch! |
@@ -2,7 +2,7 @@ | |||
# Licensed under the GNU Affero General Public License (AGPL). | |||
# See License.AGPL.txt in the project root for license information. | |||
|
|||
FROM eu.gcr.io/gitpod-core-dev/build/buildkit:v0.12.2-gitpod.1 | |||
FROM eu.gcr.io/gitpod-core-dev/build/buildkit:v0.12.5-gitpod.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is already pushed to GCR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker run --rm -it eu.gcr.io/gitpod-core-dev/build/buildkit:v0.12.5-gitpod.0 --version
buildkitd github.com/moby/buildkit v0.12.5-4-gaf7854806 af7854806a5721a31ef1c22b18ea434882687711
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, drive-by changes to fix linter issues for preview scripts
4922066
to
954dfb7
Compare
Description
Update to our latest buildkit fork, which is on v0.12.5.
Related Issue(s)
Fixes ENG-1639
How to test
Using this test repo: https://github.com/kylos101/gitpod-custom-image
gp validate
and open the debug workspaceDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold