Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image-builder-bob] update buildkit version #19383

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Feb 2, 2024

Description

Update to our latest buildkit fork, which is on v0.12.5.

Related Issue(s)

Fixes ENG-1639

How to test

Using this test repo: https://github.com/kylos101/gitpod-custom-image

  1. Do an image build from this preview environment and start a workspace:
    • image
  2. Do the same image build from a Gitpod workspace in this preview environment using gp validate and open the debug workspace
    • image

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@kylos101
Copy link
Contributor Author

kylos101 commented Feb 2, 2024

Related to #19382 ...which hit a limit due to lets encrypt rate limiting. Good luck, new branch!

@roboquat roboquat added size/S and removed size/XS labels Feb 2, 2024
@kylos101 kylos101 marked this pull request as ready for review February 2, 2024 20:34
@kylos101 kylos101 requested a review from a team as a code owner February 2, 2024 20:34
@@ -2,7 +2,7 @@
# Licensed under the GNU Affero General Public License (AGPL).
# See License.AGPL.txt in the project root for license information.

FROM eu.gcr.io/gitpod-core-dev/build/buildkit:v0.12.2-gitpod.1
FROM eu.gcr.io/gitpod-core-dev/build/buildkit:v0.12.5-gitpod.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is already pushed to GCR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker run --rm -it eu.gcr.io/gitpod-core-dev/build/buildkit:v0.12.5-gitpod.0 --version
buildkitd github.com/moby/buildkit v0.12.5-4-gaf7854806 af7854806a5721a31ef1c22b18ea434882687711

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roboquat roboquat added size/XS and removed size/S labels Feb 5, 2024
@kylos101 kylos101 changed the title [workspace-cluster] update image for gen108 [image-builder-bob] update buildkit version Feb 5, 2024
Also, drive-by changes to fix linter issues for preview scripts
@kylos101 kylos101 force-pushed the kylos101/gen108-image-2 branch from 4922066 to 954dfb7 Compare February 5, 2024 23:15
@roboquat roboquat merged commit 85274ef into main Feb 6, 2024
37 checks passed
@roboquat roboquat deleted the kylos101/gen108-image-2 branch February 6, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants