Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding prebuild status filter to repo configs list ui #19205

Merged
merged 13 commits into from
Dec 8, 2023

Conversation

selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Dec 6, 2023

Description

Adding a Prebuild status filter to Imported Repositories list that lets a user optionally filter by prebuilds being enabled or disabled.

Light Dark
image image
  • I also added a new <Select> component to podkit for this UI and tried to style it along our latest designs in figma. It's pretty close, but there's a few states we can improve the styles with I think to get it closer to the designs.
  • I updated the query we use for searching projects to optionally allow for this new filter.
Summary generated by Copilot

🤖[deprecated] Generated by Copilot at 826dbd8

This pull request adds a new feature to filter projects and configurations by their prebuilds enabled setting. It modifies the project database, the configuration service, and the public API to support this feature. It also adds a new test case for the project database. The affected files are project-db.ts, project-db-impl.ts, project-db.spec.db.ts, configuration.proto, configuration.pb.go, configuration_pb.ts, configuration-service-api.ts, and projects-service.ts.

Related Issue(s)

Fixes EXP-1001

How to test

  • Import a few repositories and enable prebuilds on at least one of them.
  • Go back to the imported repos list page and try using combinations of the search box and the new prebuild status dropdown filter.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Sorry, something went wrong.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@radix-ui/react-select 2.0.0 None +2 435 kB benoitgrelard

@selfcontained selfcontained changed the title Brad/config prebuild filter Adding prebuild status filter to repo configs list ui Dec 7, 2023
@selfcontained selfcontained force-pushed the brad/config-prebuild-filter branch from 9eeed70 to e2b2a19 Compare December 7, 2023 22:20
@selfcontained selfcontained marked this pull request as ready for review December 8, 2023 00:02
@selfcontained selfcontained requested a review from a team as a code owner December 8, 2023 00:02
@mustard-mh
Copy link
Contributor

Prebuild enable failed

image

@mustard-mh
Copy link
Contributor

We may need better respond error? It's because I don't grant repo read permission on provider Github.

image

@mustard-mh
Copy link
Contributor

After enable all prebuild for all Repository, and filter with disable it show me empty with import (don't think this is expected? It should only show in no filter + no repo)

image

@mustard-mh
Copy link
Contributor

mustard-mh commented Dec 8, 2023

Should this filter becomes a router like what we did with name?

image

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great. Just one comment about the state where a filter boils the result down to 0 entries.

@filiptronicek
Copy link
Member

filiptronicek commented Dec 8, 2023

@mustard-mh Prebuild enable failed

You're looking for EXP-804 - Brad is working on this separately

@selfcontained
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 85fb744 into main Dec 8, 2023
@roboquat roboquat deleted the brad/config-prebuild-filter branch December 8, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants