-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding prebuild status filter to repo configs list ui #19205
Merged
Merged
+470
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
826dbd8
to
bb4e03b
Compare
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
9eeed70
to
e2b2a19
Compare
filiptronicek
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great. Just one comment about the state where a filter boils the result down to 0 entries.
You're looking for EXP-804 - Brad is working on this separately |
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a Prebuild status filter to Imported Repositories list that lets a user optionally filter by prebuilds being enabled or disabled.
<Select>
component to podkit for this UI and tried to style it along our latest designs in figma. It's pretty close, but there's a few states we can improve the styles with I think to get it closer to the designs.Summary generated by Copilot
🤖[deprecated] Generated by Copilot at 826dbd8
This pull request adds a new feature to filter projects and configurations by their prebuilds enabled setting. It modifies the project database, the configuration service, and the public API to support this feature. It also adds a new test case for the project database. The affected files are
project-db.ts
,project-db-impl.ts
,project-db.spec.db.ts
,configuration.proto
,configuration.pb.go
,configuration_pb.ts
,configuration-service-api.ts
, andprojects-service.ts
.Related Issue(s)
Fixes EXP-1001
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold