Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'create-pull-request' GitHub Action to v4 #11721

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

felladrin
Copy link
Contributor

Description

Update 'create-pull-request' GitHub Action to v4.
Because team-reviewers is not being set when using v3 (see the latest PR created with that template).

Related Issue(s)

None.

How to test

It has already been tested: see this PR created from this template that uses v4.

Release Notes

NONE

Documentation

None.

Werft options:

  • /werft with-preview

Because `team-reviewers` is not being set when using v3.
@roboquat roboquat merged commit c104e29 into main Jul 28, 2022
@roboquat roboquat deleted the felladrin/patch-workflow branch July 28, 2022 11:28
@felladrin
Copy link
Contributor Author

felladrin commented Jul 28, 2022

Unfortunately, I've just noticed the team-reviewer property wasn't working for that other PR.
It has actually set the reviewer based on the file changed, which belongs to the IDE team.
image

So I've checked the issues from the GitHub Action and found this:

Maybe we can reuse this token from Robo Quat:

Or we create a new one.

@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants