Update CSS selector for base repository on gitlab.com #185
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually tested using Firefox developer edition to confirm the issue is fixed (note the "could not be verified" confirming it's running the locally built/packaged version):
|
RicePatrick
force-pushed
the
fix-gl-repo-selector
branch
from
8c17b0a to
c6d692a
Compare
RicePatrick
commented
Jan 31, 2025
| @@ -78,7 +78,7 @@ describe("Query Selector Tests", function () { | |||
|
|
|||
| async function resolveSelector(page: Page, selector: string) { | |||
| if (selector.startsWith("xpath:")) { | |||
| return (await page.$x(selector.slice(6)))[0] || null; | |||
There was a problem hiding this comment.
This just fixes an issue where depending on how quickly the typescript plugin initializes in VSCode, you can get a Property '$x' does not exist on type 'Page' error when running pnpm test
filiptronicek
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Hey @RicePatrick 👋, looks like you beat me to it 😄.
Works as advertised and code looks great, let's ship it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request fixes a broken CSS selector that caused the "Open" button to not appear on the base repository view on GitLab. The MR view worked properly still.
How to test
The tests were updated to address puppeteer version changes (and one typescript oddity). Using
pnpm buildandpnpm packageon firefox now requires using Firefox Developer Edition due to package signature requirements./hold
Fixes CLC-1116