Added tests for empty commit messages #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
reviewed
Oct 4, 2022
lyrixx
approved these changes
Oct 4, 2022
|
Could you also close the issue #61? |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the issue #61, I added tests to test the case for empty commit messages.
I used the LogPaser.php from 2014 to write the tests and was able to reproduce the same exception.
I figured out though that the newer version of gitlib already got the issue covered and that the issue is, in fact, was already fixed.
No new tag/version is needed, but it would be good to have these regression tests to see that it was indeed fixed.
Pinging @lyrixx