Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrations: support self-hosted providers from gkdev #3901

Closed
d13 opened this issue Dec 20, 2024 · 0 comments · Fixed by #3922
Closed

Integrations: support self-hosted providers from gkdev #3901

d13 opened this issue Dec 20, 2024 · 0 comments · Fixed by #3922
Assignees
Labels
area-autolinks Issues or features related to autolinks area-integrations Issues or features related to integrations area-launchpad Issues or features related to Launchpad feature New feature or request pending-release Resolved but not yet released to the stable edition
Milestone

Comments

@d13
Copy link
Member

d13 commented Dec 20, 2024

The goal is not to just convert over to GKdev like our other providers. We need to continue support of multiple instances of self-hosted and GKdev only supports one instance.

High level changes:

  • ✅ Send users to GKdev to connect to self-hosted GitHub or GitLab
    • ✅ if the integration exists on GKdev show the enable/disable toggle on the remote
    • ❌ if the integration does not exist: show the enable toggle and send user to GKdev
    • ✅ Show the "Connect GitHub Enterprise" on the Home View
  • ✅ Existing self-hosted integations (GitHub or GitLab) on GKdev, bring those into our system, but still support our custom self-hosted auth
  • ✅ Once we have the info, we need to register a custom provider
  • ➡️ A follow-up (Launchpad): Support GitHub Enterprise (GKDev) in Launchpad #3923
  • ➡️ Another follow-up (GitLab): Support GitLab Self Managed integration from GKDev #3934

👍 The code where this happens in remoteProviders.ts
👍 Essentially, we can just take the list of custom remotes and add another custom entry from the GKdev data, at runtime. We don't want to update their settings.json (though it might be an easy path for initial testing).

Potential gotchas:

  • During development, if GKdev doesn't provide the correct data, let's just temporarily stub the data in while we wait for GKDS/GKdev to provide the info (aka URL)

Testing

  • ✅ issue linking works
  • ✅ pull requests work
@eamodio eamodio added this to the 16.2 milestone Dec 20, 2024
@d13 d13 modified the milestone: 16.2 Dec 20, 2024
@d13 d13 added area-integrations Issues or features related to integrations area-autolinks Issues or features related to autolinks area-launchpad Issues or features related to Launchpad labels Dec 20, 2024
sergeibbb added a commit that referenced this issue Jan 9, 2025
sergeibbb added a commit that referenced this issue Jan 9, 2025
sergeibbb added a commit that referenced this issue Jan 9, 2025
sergeibbb added a commit that referenced this issue Jan 10, 2025
sergeibbb added a commit that referenced this issue Jan 10, 2025
axosoft-ramint pushed a commit that referenced this issue Jan 14, 2025
sergeibbb added a commit that referenced this issue Jan 15, 2025
sergeibbb added a commit that referenced this issue Jan 15, 2025
sergeibbb added a commit that referenced this issue Jan 15, 2025
sergeibbb added a commit that referenced this issue Jan 15, 2025
axosoft-ramint added a commit that referenced this issue Jan 15, 2025
* Adds support for GKDev Cloud GitHub Enterprise integration
(#3901, #3922)

* Associates a Cloud GitHub Enterprise provider with remote by its domain
(#3901, #3922)

* Adds GitHub Enterprize menu item
(#3901, #3922)

* Filters out GitHub's icon in the bar
(#3901, #3922)

* Makes sure that cloud version of GitHubEnterprise is used when needed
(#3901, #3922)

* Updates (minor) from code review

* Stores and uses stored values for configured integration descriptors

* Rename config integration descriptor
(#3901, #3922)

* Adds a todo for a follow-up ticket
(#3901, #3922)

---------

Co-authored-by: Eric Amodio <[email protected]>
Co-authored-by: Ramin Tadayon <[email protected]>
sergeibbb added a commit that referenced this issue Jan 15, 2025
sergeibbb added a commit that referenced this issue Jan 15, 2025
sergeibbb added a commit that referenced this issue Jan 15, 2025
sergeibbb added a commit that referenced this issue Jan 15, 2025
@axosoft-ramint axosoft-ramint added pending-release Resolved but not yet released to the stable edition feature New feature or request labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-autolinks Issues or features related to autolinks area-integrations Issues or features related to integrations area-launchpad Issues or features related to Launchpad feature New feature or request pending-release Resolved but not yet released to the stable edition
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants