byzer-org#81 byzer-org#89 fix click event and viewer larger image

githubnameting · Feb 14, 2022 · 9cda118 · 9cda118
1 parent 719dabd
commit 9cda118
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/src/components/Header/GlobalHelp.vue b/src/components/Header/GlobalHelp.vue
@@ -1,11 +1,11 @@
 
 <template>
   <div class="global-help">
-    <el-dropdown>
+    <el-dropdown @command="handleCommand">
       <i class="el-ksd-icon-help_22 drop-icon"></i>
       <el-dropdown-menu slot="dropdown" class="global-help-drop">
-        <el-dropdown-item command=""><a href="https://github.com/byzer-org" target="_blank">{{$t('menu.give_feedback')}}</a></el-dropdown-item>
-        <el-dropdown-item command=""><a href="https://docs.byzer.org/#/byzer-notebook/zh-cn/" target="_blank">{{$t('menu.Kolo_docs')}}</a></el-dropdown-item>
+        <el-dropdown-item command="https://github.com/byzer-org">{{$t('menu.give_feedback')}}</el-dropdown-item>
+        <el-dropdown-item command="https://docs.byzer.org/#/byzer-notebook/zh-cn/">{{$t('menu.Kolo_docs')}}</el-dropdown-item>
       </el-dropdown-menu>
     </el-dropdown>
   </div>
@@ -23,6 +23,10 @@ import { mapState } from 'vuex'
   }
 })
 export default class GlobalHelp extends Vue {
+
+  handleCommand (command) {
+    window.open(command)
+  }
 }
 </script>
 <style lang="scss">

diff --git a/src/page/IframeImage/index.vue b/src/page/IframeImage/index.vue
@@ -31,8 +31,7 @@ export default class IframePage extends Vue {
   detailContent = ''
 
   created () {
-    this.$router.push({name: 'result', params: window.opener.filter})
-    this.getStatus(window.opener.filter.id)
+    this.getStatus(this.$route.params.id)
   }
   
   async getStatus (id) {

diff --git a/src/page/Workspace/Notebook/ExcuteResult/index.vue b/src/page/Workspace/Notebook/ExcuteResult/index.vue
@@ -169,10 +169,7 @@ export default class ExcuteResult extends Vue {
   }
 
   drawPng () {
-    const location = this.$router.resolve({ name: 'result' })
-    window.filter = {
-      id: this.result.job_id
-    }
+    const location = this.$router.resolve({ name: 'result', params: { id: this.result.job_id }})
     window.open(location.href)
   }
   formatterValue (row, column, cellValue) {