Switch to built-in VS Code test UI unconditionally #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbartol
added
the
Complexity: Low
aeisenberg
approved these changes
Jan 11, 2024
| @@ -977,27 +971,8 @@ async function activateWithInstalledDistribution( | |||
| const testRunner = new TestRunner(dbm, cliServer); | |||
| ctx.subscriptions.push(testRunner); | |||
|
|
|||
| let testManager: TestManagerBase | undefined = undefined; | |||
| if (isCanary()) { | |||
There was a problem hiding this comment.
So previously, only our canary users were using this feature? And with this change, all users will be using it. It's probably safe since most users of the testing feature are internal and therefore using canary.
koesie10
added a commit
that referenced
this pull request
Jan 12, 2024
The custom Jest test runner was originally written to install the required extensions for the CLI integration tests. This is no longer necessary as of #3232, so we can remove all code that deals with downloading VS Code and installing extensions. The download of VS Code will now be handled by the base `VSCodeTestRunner`.
3 tasks
koesie10
added a commit
that referenced
this pull request
Jan 12, 2024
The custom Jest test runner was originally written to install the required extensions for the CLI integration tests. This is no longer necessary as of #3232, so we can remove all code that deals with downloading VS Code and installing extensions. The download of VS Code will now be handled by the base `VSCodeTestRunner`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've been using the new test UI for several months in canary builds, I've enabled that new UI unconditionally. This removes our dependency on the Test Explorer UI" and "Test Adapter Converter" extensions and related packages.
The initial commit just removes the old implementation from
test-adapter.ts, but leaves the shared base class intest-manager-base.tsintact. A later commit merges all of that code intotest-manager.tsnow that we don't have two different test managers to worry about.I've also updated both the repo readme and the extension readme to remove mentions of those two external extensions.
Fixes #1099