Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to yauzl for CodeQL CLI #3152

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Switch to yauzl for CodeQL CLI #3152

merged 1 commit into from
Dec 19, 2023

Conversation

koesie10
Copy link
Member

This switches the CodeQL CLI download to yauzl instead of unzipper. There should be no changes in behavior. I tested this manually on Insiders by removing the distribution directory and this successfully downloaded and extracted the CLI.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This switches the CodeQL CLI download to `yauzl` instead of `unzipper`.
There should be no changes in behavior. I tested this manually on
Insiders by removing the distribution directory and this successfully
downloaded and extracted the CLI.
@koesie10 koesie10 marked this pull request as ready for review December 19, 2023 12:31
@koesie10 koesie10 requested a review from a team as a code owner December 19, 2023 12:31
@koesie10 koesie10 merged commit f736adc into main Dec 19, 2023
53 checks passed
@koesie10 koesie10 deleted the koesie10/distribution-yauzl branch December 19, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants