Feed code search results into variant analysis repo lists #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norascheuch
force-pushed
the
nora/search-prompt
branch
from
302f966
to
4d9e8d9
Compare
charisk
reviewed
May 24, 2023
There was a problem hiding this comment.
This is looking really good! I've also tried it locally and it worked 🎉 I have some comments/questions but they're all pretty small.
What is the plan in terms of releasing? Are we planning to release as is? If so, then we'll need to update the CHANGELOG. If we want to keep it unveiled until we implement progress notifications etc. then it might be worth feature flagging it (or just setting the command visibility to false for now)
extensions/ql-vscode/test/unit-tests/databases/config/db-config-store.test.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/test/unit-tests/databases/config/db-config-store.test.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/test/vscode-tests/minimal-workspace/databases/db-panel-rendering.test.ts
Show resolved
Hide resolved
charisk
reviewed
May 26, 2023
charisk
reviewed
May 26, 2023
|
Sorry I only just thought about it :( we should add an entry in the CHANGELOG, for this awesome feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to feed code search results directly to an existing variant analysis repositories list. By entering a code language and a search query that can be developed and refined using the GitHub Code Search UI the user can now feed results directly into a MRVA list.
Additionally this PR introduces a restriction on list size. When using the new code search or adding a repo using the UI actions only up to 1000 items will be stored on a list. This restriction can be circumvented by adding repos to the config json directly and is not enforced with validation.
Checklist
ready-for-doc-reviewlabel there.