Ensure results view is opened in column beside

[aeisenberg]

The results view will always open next to the current editor.

This restores previous behaviour of the results view. Question: Do we want our other views to have the same behaviour?

Previously, our users specifically asked for the results view to open in a way that would not block the currently active editor.

Fixes #1556

Checklist

• CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
• Issues have been created for any UI or other user-facing changes made by this pull request.
• [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

[aeisenberg]

@adityasharad, this should address the issue you were having earlier with the results view not activating.

[adityasharad]

Yup looks right -- I think b8898b9 correctly ported the results view config but left the column setting hardcoded. I'll let the SecExp team review the change too, in case they have other preferences about window placement or reopening.

[angelapwen]

I tested this out and I'm getting the following error on loading the extension:

I also no longer see the eval log viewer.

I see the viewer and error on main, though, so perhaps it's to do with forcing this view while it doesn't have anything to load into it yet?

[aeisenberg]

Hmm...I can't reproduce that error. Since you're seeing it on main, it's unlikely to be related to this PR.

Can you try doing a clean build of the extension and then launch again?

[angelapwen]

Hmm...I can't reproduce that error. Since you're seeing it on main, it's unlikely to be related to this PR.

Can you try doing a clean build of the extension and then launch again?

Sorry, what I meant was that I wasn't seeing it on main. I'll do the clean build and check again.

[angelapwen]

No longer seeing the error on a clean build 👍

[aeisenberg]

As I'm thinking more, most likely this behaviour is not desirable for remote queries since they are run in a different context. Local queries are usually faster and more iterative. The results view for local queries will open automatically after the query completes. This can be annoying if it blocks the tab that you're working on. All other results views appear only when explicitly clicked, so blocking the previously active editor is not a big deal (might actually be desirable).

If you're ok with this, can I get a ✅ ?

[angelapwen]

Reasoning makes sense, 🚢

[aeisenberg]

Hmmm...no changelog for this PR. I will add one.