This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Merge vmg/fast into master #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use addrinfo to find correct address family to create socket with
This saves one String allocation per recorded metric.
This saves one String allocation per recorded metric.
This saves one String allocation per recorded metric.
This saves two String allocations per recorded metric.
This saves two String allocations per recorded metric.
This saves one String allocation per recorded metric.
According to @charliesome this is no more efficient than using the literal inline.
Reduce allocations when sending metrics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @vmg this should have been merged a while ago. We've been using this branch in production on github.com for a long time now.