Skip to content

Commit

Permalink
v0.1.0
Browse files Browse the repository at this point in the history
Release notes:

- Update dependencies to reflect new URLs.
- No code changes.
  • Loading branch information
lgarron committed Aug 12, 2020
1 parent 4223653 commit 9270322
Showing 0 changed files with 0 additions and 0 deletions.

3 comments on commit 9270322

@lgarron
Copy link
Contributor Author

@lgarron lgarron commented on 9270322 Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assets are not signed 😧

Sorry for taking a while to reply to this. I was puzzled by what you meant, and never got around to asking why. I think I understand now.

https://github.com/github/smimesign/releases shows that v0.0.13 is "Verified", while v0.1.0 is not (I forgot to set up git signing). However, the "Verified" badge has no bearing on the uploaded assets:

Screen Shot 2021-01-04 at 15 05 19

That is, the four smimesign-* build assets for each release are unsigned, and cannot be signed. GitHub only supports commit signatures for git at the moment, and release assets live outside the git repository itself.

This means the assets for v0.1.0 are not signed, but the assets for v0.0.13 and earlier versions are also not signed (and cannot be signed). You'll have to depend on the repo maintainers to upload the correct assets.

I've made a note to see if we can make this less confusing, but I thought I'd clarify here.

@btoews
Copy link
Contributor

@btoews btoews commented on 9270322 Jan 5, 2021 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgarron
Copy link
Contributor Author

@lgarron lgarron commented on 9270322 Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We restored signed builds for Windows with https://github.com/github/smimesign/releases/tag/v0.1.1

If anyone was relying on that, please try out those builds and let us know if it worked!

Please sign in to comment.