Use TSX parser instead of Typescript parser for JavaScript and JSX #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any testing that should be added for this? Previously, we would have gotten parse errors on any |
|
Let's do something like this, but with a |
Also, add a unit test for JSX in JavaScript. Co-Authored-By: Rick Winfrey <[email protected]>
|
While we were here, @rewinfrey and I also added some limited support for Type arguments in TSX (microsoft/TypeScript#22415). |
maxbrunsfeld
commented
Aug 21, 2019
| @@ -6,6 +6,7 @@ | |||
| (JsxElement | |||
| (JsxOpeningElement | |||
| (Identifier) | |||
| (Empty) | |||
There was a problem hiding this comment.
JsxOpeningElement terms now have an optional TypeArguments child. We based this off the way that type arguments are handled in the New node.
tclem
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript (and
.jsx) files can contain JSX (and cannot use TypeScript's type assertion syntax), so we need to use the TSX dialect of TypeScript when parsing and analyzing them.