Delete GitHub/Accessibility cops; point to rubocop-rails-accessibility
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
issyl0
commented
Oct 10, 2022
issyl0
commented
- Accessibility rules used to live in this gem, but https://github.com/github/rubocop-rails-accessibility now exists with the rules that were here and more. The monolith uses the new gem.
- For projects that haven't moved over yet, signpost in the README (and the eventual new gem version release notes, please) that accessibility cops have moved.
- Fixes https://github.com/github/code-scanning/issues/7337.
- Accessibility rules used to live in this gem, but https://github.com/github/rubocop-rails-accessibility now exists with the rules that were here and more. The monolith uses the new gem. - For projects that haven't moved over yet, signpost in the README (and the eventual new gem version release notes, please) that accessibility cops have moved. - Fixes github/code-scanning#7337.
issyl0
force-pushed
the
remove-accessibility-in-favour-of-new-gem
branch
from
51e86c5 to
417fc01
Compare
bolonio
reviewed
Oct 10, 2022
bolonio
approved these changes
Oct 10, 2022
Co-authored-by: Adrián Bolonio <[email protected]>
Co-authored-by: Sam Partington <[email protected]>
issyl0
added a commit
that referenced
this pull request
Oct 11, 2022
- My changes in #118 didn't quite go far enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.