Migrate accessibility rubocop rule NoPositiveTabindex from dotcom to erblint-github
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolonio
force-pushed
the
accessibility/issues/1430/migrate-a11y-rubocop-rules-no-positive-tabindex
branch
from
bb358f2
to
ca3930a
Compare
owenniblock
approved these changes
Jul 28, 2022
added 2 commits
July 29, 2022 17:32
…ocop-rules-no-positive-tabindex
added 2 commits
August 1, 2022 09:38
khiga8
reviewed
Aug 1, 2022
| @@ -0,0 +1,28 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
There was a problem hiding this comment.
I didn’t put the tests inside a subfolder because bundle exec rake doesn’t find them. It only executes the test on the test folder, no subfolders
khiga8
reviewed
Aug 1, 2022
| require "minitest/autorun" | ||
| require "rubocop/cop/github/accessibility/no_positive_tabindex" | ||
|
|
||
| class NoPositiveTabindex < CopTest |
There was a problem hiding this comment.
I didn’t put the tests inside a subfolder because bundle exec rake doesn’t find them. It only executes the test on the test folder, no subfolders
…ocop-rules-no-positive-tabindex
bolonio
deleted the
accessibility/issues/1430/migrate-a11y-rubocop-rules-no-positive-tabindex
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The motivation of rubocop-github is to open-source our accessibility rubocop rules so non-GitHub people can benefit from them, have a space to provide comprehensive rule documentation, and also allow rules to be shared between Rails projects.
This PR migrates the accessibility rule
NoPositiveTabindexfrom dotcom to rubocop-githubRelated Issue