simplify check

github · Apr 9, 2024 · 0ea9a33 · 0ea9a33
1 parent 2eea686
commit 0ea9a33
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/lib/github-pages-health-check/domain.rb b/lib/github-pages-health-check/domain.rb
@@ -238,21 +238,13 @@ def non_github_pages_ip_present?
           .any? { |a| !github_pages_ip?(a.address.to_s) }
       end
 
-      # Is the domain's first response a CNAME to a pages domain or a domain to pages?
+      # Is the domain's first response a CNAME to a pages domain?
       def cname_to_github_user_domain?
         # If the domain does not match check if the host value points to a pages
         # domain.
         #
         # e.g 'www.domain.com' -> 'domain.com' -> 'Pages' is valid
-        if cname? && !cname_to_pages_dot_github_dot_com?
-          # CNAME points to Pages
-          if cname.pages_domain?
-            return true
-          # CNAME points to a domain which might point to Pages
-          else
-            return Domain.redundant(host)
-          end
-        end
+        cname? && !cname_to_pages_dot_github_dot_com? && (cname.pages_domain? || Domain.redundant(host))
       end
 
       # Is the given domain a CNAME to pages.github.(io|com)