-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parkr jekyll3.10 #919
Parkr jekyll3.10 #919
Conversation
No functionality is changed. Since Ruby 3.0 dropped webrick and Ruby 3.4 is going to drop csv, this adds them back as dependencies. https://jekyllrb.com/news/2024/06/23/jekyll-3-10-0-released/
Might be best to include Webrick in the gem spec directly? The way it is now folks will ask to upgrade it, but if it's in the gemspec directly then you can set it to be |
Instead of in the dependencies like in #914? |
Yeah, that's what I was thinking. Anything in dependencies.rb is just more to manage without a lot of gain. It also doesn't matter for https://pages.github.com/versions/ since it's not used to build sites. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github-pages](https://togithub.com/github/pages-gem) | `231` -> `232` | [![age](https://developer.mend.io/api/mc/badges/age/rubygems/github-pages/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/github-pages/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/github-pages/231/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/github-pages/231/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/pages-gem (github-pages)</summary> ### [`v232`](https://togithub.com/github/pages-gem/releases/tag/v232) [Compare Source](https://togithub.com/github/pages-gem/compare/v231...v232) #### What's Changed - Bump docker/build-push-action from 5 to 6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/github/pages-gem/pull/916](https://togithub.com/github/pages-gem/pull/916) - Fix obscured gemfile issue by [@​mrmanc](https://togithub.com/mrmanc) in [https://github.com/github/pages-gem/pull/912](https://togithub.com/github/pages-gem/pull/912) - Add webrick as Ruby 3 doesn’t include it by [@​mrmanc](https://togithub.com/mrmanc) in [https://github.com/github/pages-gem/pull/914](https://togithub.com/github/pages-gem/pull/914) - Update nokogiri CVE-2024-25062 by [@​naxhh](https://togithub.com/naxhh) in [https://github.com/github/pages-gem/pull/911](https://togithub.com/github/pages-gem/pull/911) - Parkr jekyll3.10 by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/919](https://togithub.com/github/pages-gem/pull/919) - Fix improperly bound regex by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/921](https://togithub.com/github/pages-gem/pull/921) - Prep 232 by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/923](https://togithub.com/github/pages-gem/pull/923) #### New Contributors - [@​naxhh](https://togithub.com/naxhh) made their first contribution in [https://github.com/github/pages-gem/pull/911](https://togithub.com/github/pages-gem/pull/911) **Full Changelog**: github/pages-gem@v231...v232 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/slsa-framework/slsa). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> --------- Signed-off-by: Mend Renovate <[email protected]> Signed-off-by: Tom Hennen <[email protected]> Co-authored-by: Tom Hennen <[email protected]>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github-pages](https://togithub.com/github/pages-gem) | `"~> 231"` -> `"~> 232"` | [![age](https://developer.mend.io/api/mc/badges/age/rubygems/github-pages/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/github-pages/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/github-pages/231/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/github-pages/231/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/pages-gem (github-pages)</summary> ### [`v232`](https://togithub.com/github/pages-gem/releases/tag/v232) [Compare Source](https://togithub.com/github/pages-gem/compare/v231...v232) #### What's Changed - Bump docker/build-push-action from 5 to 6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/github/pages-gem/pull/916](https://togithub.com/github/pages-gem/pull/916) - Fix obscured gemfile issue by [@​mrmanc](https://togithub.com/mrmanc) in [https://github.com/github/pages-gem/pull/912](https://togithub.com/github/pages-gem/pull/912) - Add webrick as Ruby 3 doesn’t include it by [@​mrmanc](https://togithub.com/mrmanc) in [https://github.com/github/pages-gem/pull/914](https://togithub.com/github/pages-gem/pull/914) - Update nokogiri CVE-2024-25062 by [@​naxhh](https://togithub.com/naxhh) in [https://github.com/github/pages-gem/pull/911](https://togithub.com/github/pages-gem/pull/911) - Parkr jekyll3.10 by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/919](https://togithub.com/github/pages-gem/pull/919) - Fix improperly bound regex by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/921](https://togithub.com/github/pages-gem/pull/921) - Prep 232 by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/923](https://togithub.com/github/pages-gem/pull/923) #### New Contributors - [@​naxhh](https://togithub.com/naxhh) made their first contribution in [https://github.com/github/pages-gem/pull/911](https://togithub.com/github/pages-gem/pull/911) **Full Changelog**: github/pages-gem@v231...v232 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github-pages](https://togithub.com/github/pages-gem) | `231` -> `232` | [![age](https://developer.mend.io/api/mc/badges/age/rubygems/github-pages/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/github-pages/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/github-pages/231/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/github-pages/231/232?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/pages-gem (github-pages)</summary> ### [`v232`](https://togithub.com/github/pages-gem/releases/tag/v232) [Compare Source](https://togithub.com/github/pages-gem/compare/v231...v232) #### What's Changed - Bump docker/build-push-action from 5 to 6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/github/pages-gem/pull/916](https://togithub.com/github/pages-gem/pull/916) - Fix obscured gemfile issue by [@​mrmanc](https://togithub.com/mrmanc) in [https://github.com/github/pages-gem/pull/912](https://togithub.com/github/pages-gem/pull/912) - Add webrick as Ruby 3 doesn’t include it by [@​mrmanc](https://togithub.com/mrmanc) in [https://github.com/github/pages-gem/pull/914](https://togithub.com/github/pages-gem/pull/914) - Update nokogiri CVE-2024-25062 by [@​naxhh](https://togithub.com/naxhh) in [https://github.com/github/pages-gem/pull/911](https://togithub.com/github/pages-gem/pull/911) - Parkr jekyll3.10 by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/919](https://togithub.com/github/pages-gem/pull/919) - Fix improperly bound regex by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/921](https://togithub.com/github/pages-gem/pull/921) - Prep 232 by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/923](https://togithub.com/github/pages-gem/pull/923) #### New Contributors - [@​naxhh](https://togithub.com/naxhh) made their first contribution in [https://github.com/github/pages-gem/pull/911](https://togithub.com/github/pages-gem/pull/911) **Full Changelog**: github/pages-gem@v231...v232 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/slsa-framework/slsa). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> --------- Signed-off-by: Mend Renovate <[email protected]> Signed-off-by: Arnaud J Le Hors <[email protected]> Co-authored-by: Arnaud J Le Hors <[email protected]>
Same as #917 but with an additional
jekyll-commonmark-ghpages
bump.Also reconsider #914 by moving
webrick
to a gemspec dependency.