Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create publish-gem.yml #898

Merged
merged 26 commits into from
Jan 9, 2024
Merged

Create publish-gem.yml #898

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f3ee583
Create publish-gem.yml
tsusdere Jan 2, 2024
bb1d50e
add ruby version
tsusdere Jan 2, 2024
ecb7a8a
Update publish-gem.yml
tsusdere Jan 2, 2024
31bce95
Update publish-gem.yml
tsusdere Jan 2, 2024
2d66a27
Update Dockerfile
tsusdere Jan 2, 2024
351e4a7
Update Dockerfile
tsusdere Jan 2, 2024
8c97daf
Update publish-gem.yml
tsusdere Jan 2, 2024
7337649
update gem update
YiMysty Jan 2, 2024
549fa79
upgrade to 2.7.8
YiMysty Jan 2, 2024
d7615e1
Update publish-gem.yml
tsusdere Jan 2, 2024
a1e407c
change ruby version
tsusdere Jan 3, 2024
3980c1a
add version to update
tsusdere Jan 3, 2024
90b989b
revert to working update
tsusdere Jan 3, 2024
7c86cdb
add 3.2
tsusdere Jan 3, 2024
d73437f
remove 2.6
tsusdere Jan 3, 2024
9ccadb7
Update push.yml
tsusdere Jan 4, 2024
8dd7a80
Update .travis.yml
tsusdere Jan 4, 2024
48da3d2
test 3.4 for CI
tsusdere Jan 4, 2024
460897f
update version
tsusdere Jan 4, 2024
798d778
update
tsusdere Jan 4, 2024
fa1b540
change ruby version
tsusdere Jan 5, 2024
117fd75
update jekyll
tsusdere Jan 5, 2024
ed0d437
Update cibuild-docker
tsusdere Jan 5, 2024
91e261d
Update .rubocop.yml
tsusdere Jan 5, 2024
c31c982
Update github-pages.gemspec
tsusdere Jan 5, 2024
47322fd
Update Gemfile
tsusdere Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/publish-gem.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Publish Gem

on:
release:
types: [released]

jobs:
release:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.3"
- name: Build gem
run: |
gem build github-pages.gemspec
- name: Publish
Copy link
Contributor

@YiMysty YiMysty Jan 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should only run when merge into master branch or tag release I think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to instead run the job when we merge into master branch?

on:
  push:
    branches:
      - main

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

on:
  release:
    types: [released]

run: |
gem push github-pages.gem --key ${{ secrets.PAGES_GEM_PUBLISH }}
4 changes: 2 additions & 2 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ jobs:
strategy:
matrix:
ruby:
- 2.6
- 2.7
- 3.0
- 3.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote these so they become strings when parsed rather than floats.

steps:
- uses: actions/checkout@v4
- name: script/cibuild-docker
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.7.3
3.3
5 changes: 2 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
language: ruby
rvm:
- 2.5
- 2.6
- 2.7
- 3.0
- 3.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove this Travis config file entirely.


branches:
only:
Expand Down
5 changes: 3 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG RUBY_VERSION=2.7.3
ARG RUBY_VERSION=3.3
FROM ruby:$RUBY_VERSION

RUN apt-get update \
Expand All @@ -8,7 +8,8 @@ RUN apt-get update \
make \
nodejs

RUN gem update --system
# final version for rubygems-update to supoprt ruby 2.7, consider removing this after upgraded to ruby 3.0
RUN gem update --system 3.4.22

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're upgrading in this PR, you can probably remove this.

COPY .git /src/gh/pages-gem/.git
COPY Gemfile* /src/gh/pages-gem/
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.alpine
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ruby:2.7.3-alpine
FROM ruby:3.3-alpine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe CI is attempting to pass the RUBY_VERSION build arg, but here it's always ruby 3.3.

Either remove the RUBY_VERSION arg from CI and script/cibuild-docker or support it here in Dockerfile.

RUN apk update && apk add --no-cache \
git
Expand Down
2 changes: 1 addition & 1 deletion script/cibuild-docker
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -ex

# Set the ruby version in the Action definition matrix.
: "${RUBY_VERSION:="2.7.3"}"
: "${RUBY_VERSION:="3.3"}"

docker build --build-arg "RUBY_VERSION=$RUBY_VERSION" -t github-pages .
docker run --rm --workdir /src/gh/pages-gem github-pages script/cibuild
Loading