Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test PR for dotnet-analyzers-action #20
base: main
Are you sure you want to change the base?
Test PR for dotnet-analyzers-action #20
Changes from 26 commits
faf588d
1437956
6440106
d31074a
e586115
c172fe7
e8c2e5b
729f84a
eaaa72f
7c1e8c4
17ffd85
ae05100
e2e7a99
8e809b3
b4f4180
f79a17b
3d903e8
abb3b28
6ccf8b3
f18384b
5b5d04d
98647a5
b7cc458
4f3b742
8519309
c2e5731
acf4b2b
a5b8536
aae06f9
3bce568
034fca2
d43114b
8dfd6b5
540902a
9cf7b9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want to upload results from .NET analyzers run to security tab or not, as the analyzers are not restricted to just security analyzers. Will have to talk with @mikadumont to decide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub would prefer if only security results were in the tab, as noise will make people not pay attention to critical issues. Should likely remove this for now. There may be a way to selectively export security-only rules with Guardian and a policy, although I am unfamiliar if we have that capability now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will likely be the new repo URL, but have to confirm with @mikadumont
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldnt it be called code-analysis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I will fix it up in the cloned repo.
This file was deleted.