Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new ms language folder #1737

Merged
merged 19 commits into from
Aug 10, 2020
Merged

Created new ms language folder #1737

merged 19 commits into from
Aug 10, 2020

Conversation

KaynenStrife
Copy link
Contributor

@KaynenStrife KaynenStrife commented Aug 9, 2020

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


@KaynenStrife KaynenStrife dismissed a stale review via 5566335 August 9, 2020 17:22
@KaynenStrife
Copy link
Contributor Author

Hi, I'm new to GitHub and I decided to translate the opensource.guide to the malay language as a practice on how to use GitHub, is it possible to help explain to me how to properly merge the translation I made into this repository?

If possible some examples of how to resolve the issue of not being able to merge?

@KaynenStrife KaynenStrife dismissed a stale review via 4055b5c August 9, 2020 17:50
@KaynenStrife
Copy link
Contributor Author

How do i fix the "GitHub Metadata: No GitHub API authentication could be found. Some fields may be missing or have incorrect data." error?

@mlinksva
Copy link
Contributor

mlinksva commented Aug 9, 2020

@KaynenStrife you can ignore that message, it's expected and isn't causing CI to not pass.

@KaynenStrife
Copy link
Contributor Author

Thanks for telling me @mlinksva , sorry if I am making rookie mistakes, but I can't seem to get the merge....

Something about the Post Restore bundler cache.

Am I doing something wrong?

@mlinksva
Copy link
Contributor

mlinksva commented Aug 9, 2020

@KaynenStrife apologies, I missed your first question above. When tests pass on this PR I or another maintainer can merge it.

You've probably already seen https://github.com/github/opensource.guide/blob/master/docs/translations.md already, just pointing it out in case. Looking at what other translations have done may also be helpful.

I think what you're referring to as "merge" is actually tests passing. " Post Restore bundler cache" is an informational message, post-tests. The thing to pay attention to is the tests themselves. It looks like there are currently 33 failures, listed above this line. It's not unusual to have a lot of small failures triggered by formatting or other errors which can be hard to figure out but are ultimately small. If the failures listed at the link above don't make sense let me know and I can try to take a closer look.

@@ -0,0 +1,6 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is probably causing many of the test failures. There shouldn't be a README file in translation folders. Delete it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, i'm going to remove it and then push again. Then see what errors there are and try to fix those.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more accurate, I see that there is a README in zh-hant. It is OK to have a README, but the key thing is if it exists, it can't have frontmatter -- the beginning of the file surrounded by --- lines, which causes it to be rendered as a page in the site.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I've noticed that inside the en building-community file, that the "act immediately" link leads to a 404 page, is that intentional or an error that needs to be fixed? If it's intentional do I ignore the error that will also occur in the version I am currently translating to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also occurs in the "ask them to leave", "explain why", "many ways to contribute", "A friendly README", "more than just a set of instructions", "your CONTRIBUTING file", link all lead to 404 pages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is it only an issue on my side? Sorry if I keep spamming issues left and right, I'm not familiar with GitHub and its many functionalities.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That error is actually in the ms folder, see https://github.com/github/opensource.guide/pull/1737/checks?check_run_id=964363770#step:7:38

I'll make a comment at the line causing the problem.


Apabila komuniti anda bergelut dengan masalah yang sukar, kemarahan mungkin akan meningkat. Orang mungkin menjadi marah atau kecewa dan mengeluarkannya satu sama lain, atau pada anda.

Tugas anda sebagai penyelenggara adalah untuk memastikan situasi ini tidak meningkat. Walaupun anda mempunyai pendapat yang kuat mengenai topik ini, cubalah mengambil kedudukan sebagai moderator atau fasilitator, daripada melompat ke dalam pertengkaran dan mendorong pandangan anda. Sekiranya seseorang bersikap tidak baik atau memonopoli perbualan, [act immediately](../building-community/#dont-tolerate-bad-actors) agar perbincangan tetap sopan dan produktif.
Copy link
Contributor

@mlinksva mlinksva Aug 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaynenStrife the fragment identifier #dont-tolerate-bad-actors will be different because the headings (which generate fragment identifiers) are translated.

Take a look at the fragment identifiers in another translation, eg the same file in zh-hant, for how to do it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The id translation may be another good example to look at -- translated headings, and you can see that the fragment identifiers are lowercased, with - substituting for spaces.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to set the internal links right, I hope this fulfills the conditions required for a merge to occur.

Also, thank you very much @mlinksva for pointing me in the right direction. Would have used up a full day just to figure out where my error came from.

Papunef
Papunef previously approved these changes Aug 9, 2020
@KaynenStrife KaynenStrife dismissed stale reviews from Papunef and ghost via f53cb84 August 9, 2020 20:38
Papunef
Papunef previously approved these changes Aug 9, 2020
@KaynenStrife
Copy link
Contributor Author

@mlinksva , what other changes do I need to make?

@mlinksva mlinksva dismissed a stale review via dcfcb0b August 9, 2020 23:34
Copy link
Contributor

@mlinksva mlinksva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few sentences or sentence fragments that aren't translated. I suspect these were just overlooked, but if there's a good reason to leave them untranslated, let me know.


* Sekiranya anda mempunyai komuniti yang cukup besar, **menghantar surat berita atau menulis catatan blog** mengucapkan terima kasih kepada penyumbang. Rust's [This Week in Rust](https://this-week-in-rust.org/) and Hoodie's [Shoutouts](http://hood.ie/blog/shoutouts-week-24.html) adalah dua contoh yang baik.

* **Berikan akses kepada setiap penyumbang.** @felixge mendapati bahawa ini menjadikan orang[more excited to polish their patches](https://felixge.de/2013/03/11/the-pull-request-hack.html), and he even found new maintainers for projects that he hadn't worked on in awhile.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete translation?


Setiap pengurus pakej boleh menggunakan definisi "download" yang sedikit berbeza, dan muat turuntuk mengesan statistik penggunaan di banyak pengurus pakej yang popular.

Sekiranya projek anda berada di GitHub, arahkan kembali ke halaman "Traffic". Anda boleh menggunakanun tidak semestinya berkaitan dengan pemasangan atau penggunaan, tetapi menyediakan beberapa asas untuk perbandingan. Cuba gunakan [Libraries.io](https://libraries.io/) to track usage statistics across many popular package managers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete translation?


Sekiranya projek anda berada di GitHub, arahkan kembali ke halaman "Traffic". Anda boleh menggunakanun tidak semestinya berkaitan dengan pemasangan atau penggunaan, tetapi menyediakan beberapa asas untuk perbandingan. Cuba gunakan [Libraries.io](https://libraries.io/) to track usage statistics across many popular package managers.

If your project is on GitHub, navigate again to the "Traffic" page. You can use the [clone graph](https://github.com/blog/1873-clone-graphs) to see how many times your project has been cloned on a given day, broken down by total clones and unique cloners.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete translation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I've accidentally overlooked those short snippets. Terribly sorry. Just filled in the missing translated portions. Should be okay now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do note that there are many words that the Malay language has adopted from English such as "popular" or words that are very closely similar such as "Analysis"(English) and "Analisis"(Malay). So it is totally normal for some of the words to look like typos of normal English words.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna go to bed first, it's 8:40am over here and I've stayed up all night doing this translation. @mlinksva Thanks for pointing out the many mistakes that I've made and point me in the right direction. I will probably continue translating this in another 4/5 hours from now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and merged. Feel free to make a new PR if you'd like to further improve the translation. Thanks!

Copy link
Contributor

@mlinksva mlinksva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this translation @KaynenStrife and working through fixes!

@mlinksva mlinksva merged commit ea36935 into github:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants