Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The module is POSIX, not Posix #456

Merged
merged 1 commit into from
Feb 18, 2015
Merged

The module is POSIX, not Posix #456

merged 1 commit into from
Feb 18, 2015

Conversation

gjtorikian
Copy link
Contributor

Ugh, took me forever to figure out why the latest github-markup wasn't working on production. The module is POSIX, not Posix.

Defined here: c272303#diff-02c4c8b8f144186ddb12a3d0a5853cd5

/cc @bkeepers @dometto

gjtorikian added a commit that referenced this pull request Feb 18, 2015
The module is POSIX, not Posix
@gjtorikian gjtorikian merged commit d4f1861 into master Feb 18, 2015
@gjtorikian gjtorikian deleted the fix-posix-check branch February 18, 2015 04:38
@bkeepers
Copy link
Contributor

Doh. I wonder if we could add a test case to account for this.

@dometto
Copy link
Contributor

dometto commented Feb 18, 2015

Ouch, sorry about that! Should be possible to test the posix-spawn behavior by adding it as a (MRI-only) development dependency in the Gemfile. I'll try to submit a PR with a unit test later this week.

/cc @bartkamphorst

@dometto
Copy link
Contributor

dometto commented Apr 4, 2015

Hmm, not sure how to sensibly test which method is being defined (the POSIX::Spawn or the Open3 variant), other than something like

assert_equal defined?(POSIX::Spawn), true if RUBY_PLATFORM != 'java'

@lisas1234
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants