resolves #1258 upgrade to Asciidoctor 2.0.x #1264
Conversation
mojavelinux
commented
Apr 2, 2019
mojavelinux
commented
- upgrade to Asciidoctor 2.0.x (starting with 2.0.5)
- switch to fuzzy version match for asciidoctor gem
- disable sectanchors (since they get removed by the sanitizer anyway)
- use formal xref macro for interdocument xref in test
- add test for toggling the document title using showtitle/!showtitle
- add test to verify toc is generated at top of document when toc attribute is set
- upgrade to Asciidoctor 2.0.x (starting with 2.0.5) - switch to fuzzy version match for asciidoctor gem - disable sectanchors (since they get removed by the sanitizer anyway) - use formal xref macro for interdocument xref in test - add test for toggling the document title using showtitle/!showtitle - add test to verify toc is generated at top of document when toc attribute is set
|
@kivikakk Now that Asciidoctor follows semantic versioning, we can safely use a fuzzy match on the patch version. If you'd rather stick with a fixed version, just let me know and I'd be happy to comply. I also added a few more tests for scenarios I could think of that are relevant for rendering AsciiDoc on GitHub. |
|
Nice! All passing locally, CI should be green any moment, but I'll prepare a prerelease gem of markup and run the full github.com CI suite with that in place and see if anything falls out. |
|
Just fired off CI, it's the end of my work day so I'll check back in first thing tomorrow! Should be pretty straightforward. 👍 |
|
Excellent! Thank you so much for your time and attention. |
|
Nice! One small test change required on the dotcom end, but looking good. I'll make a new Markup release and start the process to get the change in! |
|
Thanks @kivikakk! |
|
Unfortunately I had to abort the roll-out of this; our workers fail to boot up and throw an ArgumentError with the text I'm guessing our workers do not expose a It's probably going to be difficult to change this state of affairs any time soon. Is it possible to make Asciidoctor not rely on there being a valid user home directory defined? |
|
Ah yes. In 1.5.x we had a rescue on that line. I couldn't remember why it was there, so I removed it in 2.0. Now that I know why it was there, I can restore it, document it, and push out a new version (2.0.6). I'll let you know once it's available! |
|
Thanks for the feedback! |
|
Great, thank you! (And indeed, the rescue tracks back to asciidoctor/asciidoctor#896. It's strange this happens as often as it does. My best guess is a |
|
Upstream issue: asciidoctor/asciidoctor#3238 |
|
It's indeed strange, but surprisingly prevalent. I've seen Docker containers have this same problem, so this fix turns out to be quite important. This is a good catch. |
|
@kivikakk 2.0.6 is now available with a fix. https://github.com/asciidoctor/asciidoctor/releases/tag/v2.0.6 |
|
@mojavelinux Cheers, I'll start on the upgrade work! No new Markup release is needed since the Gemfile is only used in development anyway, I'll just bump the Asciidoctor gem in my github PR. |
|
Perfect! Thank you so much. If there's anything else you need, just let me know and I'll get it taken care of asap. |
|
Thank you! Will do. |
|
➡️ https://github.com/kivikakk/what-version-of-asciidoctor-is-github-on ❗️ Let me know if anything looks off to you. |
|
💃 🕺 👏 A-M-A-Z-I-N-G ! Looks great to me. 👍 Btw, this is the page I use to test various settings, for your reference: https://github.com/opendevise/asciidoc-samples/blob/master/runtime.adoc |
|
Aaaah, super helpful, thank you! Glad it's looking good 👍 |
