Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add markup options #1249

Merged
merged 2 commits into from
Jan 6, 2019
Merged

add markup options #1249

merged 2 commits into from
Jan 6, 2019

Conversation

jinhucheung
Copy link
Contributor

add options to Gitlab::Markup::render_s

@kivikakk
Copy link
Contributor

kivikakk commented Jan 6, 2019

Excellent; thank you!

@kivikakk kivikakk merged commit 8f436ff into github:master Jan 6, 2019
@@ -92,7 +92,7 @@ def test_each_render_has_a_name
assert_equal "pod", GitHub::Markup.renderer('README.pod', '=head1').name
assert_equal "pod6", GitHub::Markup.renderer('README.pod6', '=begin pod').name

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • _@
Suggested change
assert_equal "pod6", GitHub::Markup.renderer('README.pod6', '=begin pod').name
assert_equal "pod6", GitHub::Markup.renderer('README.pod6', '=begin pod').name

_

Copy link

@unreal-person-666 unreal-person-666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants