Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't render rmd as markdown #1235

Merged
merged 1 commit into from
Oct 14, 2018
Merged

don't render rmd as markdown #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/github/markup/markdown.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class Markdown < Implementation

def initialize
super(
/md|rmd|mkdn?|mdwn|mdown|markdown|litcoffee/i,
/md|mkdn?|mdwn|mdown|markdown|litcoffee/i,
["Markdown", "RMarkdown", "Literate CoffeeScript"])
end

Expand Down
4 changes: 1 addition & 3 deletions test/markup_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# encoding: UTF-8
# encoding: utf-8

$LOAD_PATH.unshift File.dirname(__FILE__) + "/../lib"

Expand Down Expand Up @@ -78,8 +78,6 @@ def call
def test_knows_what_it_can_and_cannot_render
assert_equal false, GitHub::Markup.can_render?('README.html', '<h1>Title</h1>')
assert_equal true, GitHub::Markup.can_render?('README.markdown', '=== Title')
assert_equal true, GitHub::Markup.can_render?('README.rmd', '=== Title')
assert_equal true, GitHub::Markup.can_render?('README.Rmd', '=== Title')
assert_equal false, GitHub::Markup.can_render?('README.cmd', 'echo 1')
assert_equal true, GitHub::Markup.can_render?('README.litcoffee', 'Title')
end
Expand Down
3 changes: 0 additions & 3 deletions test/markups/README.rmd
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions test/markups/README.rmd.html
View file
Open in desktop

This file was deleted.