Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove GO111MODULE env as it is default on #608

Merged
merged 1 commit into from
Jan 17, 2023
Merged

build: remove GO111MODULE env as it is default on #608

merged 1 commit into from
Jan 17, 2023

Conversation

chenrui333
Copy link
Contributor

@jonabc
Copy link
Contributor

jonabc commented Jan 9, 2023

😢 removing the dep source would be a breaking change which I would prefer not to happen for a little while given the 4.0 release just went out with breaking changes. I'm trying to limit the amount of significant churn on the project and keeping dep support shouldn't hurt or interfere with licensed usage.

Would you mind reverting the changes related to the dep source and limit this PR to the GO111MODULE cleanup? Please create an issue to remove the dep source, and it can be handled as part of the next major version release with other breaking changes.

@chenrui333
Copy link
Contributor Author

😢 removing the dep source would be a breaking change which I would prefer not to happen for a little while given the 4.0 release just went out with breaking changes. I'm trying to limit the amount of significant churn on the project and keeping dep support shouldn't hurt or interfere with licensed usage.

Would you mind reverting the changes related to the dep source and limit this PR to the GO111MODULE cleanup? Please create an issue to remove the dep source, and it can be handled as part of the next major version release with other breaking changes.

Yeah, that makes sense.

@chenrui333 chenrui333 mentioned this pull request Jan 17, 2023
@chenrui333 chenrui333 changed the title chore: remove dep build: remove GO111MODULE env as it is default on Jan 17, 2023
@chenrui333
Copy link
Contributor Author

@jonabc should be good now. :)

@jonabc
Copy link
Contributor

jonabc commented Jan 17, 2023

the bundler 2.4 CI failure that popped up is known and was fixed by a separate PR I merged in the last hour or so. 👍 merging and thanks for the update

@jonabc jonabc merged commit 6d5b520 into github:master Jan 17, 2023
@chenrui333 chenrui333 deleted the remove-dep branch February 12, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants