bump versions of go used in tests #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Please review the pull request for any additional changes required and merge when ready. |
License updates for update-go-test-versions
- go testing now uses modules by default
|
the drift between go with modules and go without modules was getting difficult to manage so I ended up removing testing support for go without modules. To do that I moved the existing go without modules fixtures to a separate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing was done on versions 1.12 -> 1.16... all of which are old and started to cause issues in CI. It looks like 1.18 and 1.19 are the versions currently being actively supported, and I've added 1.17 in case not everyone has updated at this point. It's not feasible to test against every version of go but hopefully one unsupported prior version won't be a big deal 🤷