Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generating notice file from live computed data #572

Merged
merged 5 commits into from
Nov 14, 2022
Merged

Conversation

jonabc
Copy link
Contributor

@jonabc jonabc commented Nov 12, 2022

addresses #560 (comment)

This adds a --computed long form, -l short form option to licensed notice. When set, the command will generate a NOTICE file from dependency data computed dynamically, rather than loading dependency data from metadata files.

@jonabc
Copy link
Contributor Author

jonabc commented Nov 12, 2022

The licensed-ci GitHub Action has created a pull request containing license metadata updates based on the changes in this branch.

Please review the pull request for any additional changes required and merge when ready.

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks for the quick response to my question 😄

Comment on lines +54 to +55
method_option :computed, aliases: "-l", type: :boolean,
desc: "Whether to generate a NOTICE file using computed data or cached records"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this option be added to the licensed notices command documentation?

Copy link
Contributor Author

@jonabc jonabc Nov 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 yep, I had updated the docs locally but it looks like I never pushed the commit up to GitHub. Thanks for catching that!

@jonabc
Copy link
Contributor Author

jonabc commented Nov 14, 2022

Merging, I'll put out a new release later today

@jonabc jonabc merged commit 8f10fc9 into master Nov 14, 2022
@jonabc jonabc deleted the computed-notices branch November 14, 2022 16:16
jonabc added a commit that referenced this pull request Nov 14, 2022
### Added

- `NOTICE` files can now be generated without cached files in a repository (#572)
@jonabc jonabc mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants