-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow generating notice file from live computed data #572
Conversation
The Please review the pull request for any additional changes required and merge when ready. |
License updates for computed-notices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks for the quick response to my question 😄
method_option :computed, aliases: "-l", type: :boolean, | ||
desc: "Whether to generate a NOTICE file using computed data or cached records" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this option be added to the licensed notices
command documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 yep, I had updated the docs locally but it looks like I never pushed the commit up to GitHub. Thanks for catching that!
Merging, I'll put out a new release later today |
### Added - `NOTICE` files can now be generated without cached files in a repository (#572)
addresses #560 (comment)
This adds a
--computed
long form,-l
short form option tolicensed notice
. When set, the command will generate a NOTICE file from dependency data computed dynamically, rather than loading dependency data from metadata files.