Handle changes in materializing lazy specs in recent versions of bundler #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Please review the pull request for any additional changes required and merge when ready. |
License updates for fix-bundler-2.3.20
jonabc
added a commit
that referenced
this pull request
Aug 17, 2022
## 3.7.3 ### Fixed - Swift test fixtures build artifacts are now ignored (:tada: @CvX #524) - Running cargo test fixture setup no longer deletes test files (:tada: @CvX #525) - Bundler test fixtures are compatible with latest macOS silicon(:tada: @CvX #528) - Fix segfaults seen using licensed with ruby 3.0.4 (#530) - Fix compatibility with latest versions of bundler 2.3 (#535)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen in CI logs on a dependency update, licensed isn't working as expected for recent versions of bundler. As far as I can tell this has to do with small changes in the materialization of lazy specifications, and theres a new method
materialize_for_installationthat I can tie into to check whether materialization failed. From what I can tell it should play fine with the previous__materialize__override and should only affect newer versions of bundler that implement the method on LazySpecifications.