Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundler 2.3.19 compatibility #522

Closed
wants to merge 2 commits into from
Closed

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Jul 28, 2022

rubygems/rubygems#5070 changed the arity of __materialize__ method which broke licensed

Fixes #521

CvX added 2 commits July 28, 2022 11:03
rubygems/rubygems#5070 changed the arity of `__materialize__` method which broke `licensed`
Copy link
Contributor

@jonabc jonabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

jonabc added a commit that referenced this pull request Jul 28, 2022
taking the fix from #522
where that change is blocked by rubocop style fixes that
are in the branch this commit is authored in
@CvX CvX closed this Jul 28, 2022
@CvX CvX deleted the bundler-compat branch July 28, 2022 16:57
@CvX CvX restored the bundler-compat branch July 28, 2022 19:37
@jonabc jonabc mentioned this pull request Aug 17, 2022
@jonabc
Copy link
Contributor

jonabc commented Aug 17, 2022

Fix was included as part of #526, which was needed to get CI passing in other open PRs.

CvX added a commit to CvX/licensed that referenced this pull request Jan 17, 2023
…to fix bundler 2.4.4 incompatiblity

rubygems/rubygems#6261 changed the arity of `__materialize__` method again, which broke `licensed`
See also: github#522 😅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with Bundler 2.3.19
2 participants