improve glob when finding dependency package.json files from the yarn sources #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suggested by ljharb as an improvement by ignoring package.json files that don't represent installed packages this also moves the dependency_paths method to the shared class to consolidate the functionality across both source versions
|
The Please review the pull request for any additional changes required and merge when ready. |
License updates for yarn-npm-json-glob-fix
jonabc
added a commit
that referenced
this pull request
Jan 17, 2022
## 3.4.2 2022-01-17 ### Fixed - The yarn source will no longer evaluate package.json files that do not represent project dependencies (#439)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggested by @ljharb in #436 (comment) (🙇 !) as an improvement to the glob for finding dependency paths by ignoring package.json files that don't represent installed packages
this also moves the dependency_paths method to the shared yarn module to consolidate the functionality across both yarn source enumerator versions