Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parallel enumeration for sources #210

Merged
merged 5 commits into from
Oct 26, 2019
Merged

Use parallel enumeration for sources #210

merged 5 commits into from
Oct 26, 2019

Conversation

jonabc
Copy link
Contributor

@jonabc jonabc commented Oct 26, 2019

Following #207 and #204, this updates a few more sources to use parallel enumeration

  1. Cabal
  • when obtaining full package information from package ids
  • when recursively obtaining indirect package dependencies
  • tried when getting package ids for initial set of dependencies found in cabal files, which slowed things down in local testing
  1. Go < 1.11
    • when getting package info for all dependencies listed in root_package["Deps"]
    • cannot use when getting package version. this can potentially make many git cli calls, but by necessity of being in the target packages git repo I need to Dir.chdir package_directory, where Dir.chdir is not threadsafe.
  2. Manifest
    • when getting package versions which potentially makes many git cli calls

Speed gains observed from CI

Cabal Go Manifest
Absolute 1-3s 25-32s 0s - these were already pretty fast at 3s
Relative 10-30% 33-39% 0%

@jonabc jonabc merged commit c2897e8 into master Oct 26, 2019
@jonabc jonabc deleted the parallel-enumeration branch October 26, 2019 20:20
@jonabc jonabc mentioned this pull request Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant