Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not remove label? #12

Closed
fmigneault opened this issue May 15, 2020 · 3 comments · Fixed by #59
Closed

Option to not remove label? #12

fmigneault opened this issue May 15, 2020 · 3 comments · Fixed by #59
Labels
enhancement New feature or request

Comments

@fmigneault
Copy link

I really like the ability to automatically apply labels if a specific word is found, but having the same labels removed because the word is missing can be problematic.

For instance, I label bug to any issue that as that word, but the label was manually tagged as a bug without using the word in the body, it just gets removed at some point and we lose track of the bug!

Maybe something like follows could be considered?

bug: 
   add: false
   remove: false
   regex: 
     - bug
     - ....
fmigneault added a commit to crim-ca/weaver that referenced this issue May 24, 2020
Issue labeler removes manually added labels if it isn't matched with its configuration rules. 
This is quite annoying, and we loose manual tags, so disable it until fixed github/issue-labeler#12
@stephanmiehe
Copy link
Collaborator

@fmigneault this sounds good to me. Feel free to put a PR up and I'll review it otherwise I'll try to get to it in the near future

@stephanmiehe stephanmiehe added the enhancement New feature or request label Jun 2, 2020
@jsosulska
Copy link

I am seeing that labels are being removed as part of every run of my action, even though the output agrees the label is added. Can this be turned off?

@hawkeye116477
Copy link

Could it be possible to add condition when label will be removed? So for example, I check checkbox label added, I uncheck, then label removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants