-
Notifications
You must be signed in to change notification settings - Fork 83.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore go.work.sum #4081
Ignore go.work.sum #4081
Conversation
To further support these changes, here are some examples for popular repos ignoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These files shouldn't be commited since they are specific to a local dev environment.
Why not |
|
I'm in favor of this change - if |
Hey there, I noticed that the PR is already approved. is there an estimated timeframe for when it might be merged? Just curious and looking forward to it |
I think those gray check marks indicate that the approvals are by developers who are not CODEOWNERS. I don't even see a merge button! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for following our contribution guide and helping improve our templates!
I just finished reviewing and this looks good to me.
Reasons for making this change:
As the
go.work
file is excluded, thego.work.sum
file, which is generated based on thego.work
file, should be excluded, too.Also mentioned in fbc053f#commitcomment-73352144
Links to documentation supporting these rule changes:
Currently there isn't much documentation regarding
go.work.sum
(see golang/go#51941), the only thing I can refer to is the proposal, which suggests to not check in thego.work
file.