Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elm.gitignore #1440

Closed
wants to merge 1 commit into from
Closed

Add Elm.gitignore #1440

wants to merge 1 commit into from

Conversation

marcelbuesing
Copy link

@jasonkuhrt
Copy link

Please LGTM

@chendrix
Copy link

👍

@Apanatshka
Copy link

Complete information:

The Elm programming language is on elm-lang.org.
This gitignore ignores build artefacts and downloaded dependencies. The directory name was decided on here.

(copied from my PR, I didn't notice this one)

@bbugh
Copy link

bbugh commented Aug 6, 2015

Shouldn't this re-include elm-stuff/exact-dependencies.json, like so? If I understand correctly, that file is significant, much like Gemfile.lock.

elm.js
elm-stuff/*
!elm-stuff/exact-dependencies.json

(but I'm relatively new to Elm and could be wrong)

@chendrix
Copy link

chendrix commented Aug 6, 2015

I think it's a matter of if you're publishing a library or a "final application".

E.g. even the Ruby gitignore tells you

# for a library or gem, you might want to ignore these files since the code is
# intended to run in multiple environments; otherwise, check them in:
# Gemfile.lock
# .ruby-version
# .ruby-gemset

If you're writing a final application you may want to check in exact-dependencies.json, a library? nope.

@bbugh
Copy link

bbugh commented Aug 7, 2015

That should probably be specified in the .gitignore then, the way the Ruby one does. It's pretty important.

@shiftkey
Copy link
Member

Closing in favour of #1610 which has some extra rules around the REPL.

@shiftkey shiftkey closed this Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants