hooks: reporting GH_OST_ETA_SECONDS. ETA as part of migration context #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actions/Workflow: upload artifact
Support a complete ALTER TABLE statement in --alter
handle driver timeout error
Updates from upstream 2020 10
Initial commit: towards setting up a test suite Signed-off-by: Shlomi Noach <[email protected]>
…original table, applying AUTO_INCREMENT value onto ghost table if applicable and user has not specified AUTO_INCREMENT in alter statement
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Copying AUTO_INCREMENT value to ghost table
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Generated column as part of UNIQUE (or PRIMARY) KEY
Cut-over should wait for heartbeat lag to be low enough to succeed
Signed-off-by: Shlomi Noach <[email protected]>
All MySQL DBs limited to max 3 concurrent/idle connections
…context Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
|
branch updated after recent merge of downstream contribution. |
|
This PR passed many internal tests, merging it 👍 Thanks @shlomi-noach! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resubmission of openark#17
Hooks can now utilize
GH_OST_ETA_SECONDSenvironment variable, populated with an integer value of ETA seconds.A negative value stands for unknown ETA, as is the case at the very beginning of the migration.
The value is
0when cut-over is imminent.maintainers: this joins a list of unmerged upstream PRs while I'm progressing with downstream development. It will be difficult to identify the specific changes in this PR given the unmerged commits. But do see openark#17