Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed DECIMAL datatype #684

Merged
merged 9 commits into from
Jan 13, 2019
Merged

Fixed DECIMAL datatype #684

merged 9 commits into from
Jan 13, 2019

Conversation

shlomi-noach
Copy link
Contributor

Testing #681

Initial commit confirms the bug reported in #681

@shlomi-noach shlomi-noach mentioned this pull request Nov 28, 2018
Closed
@shlomi-noach
Copy link
Contributor Author

@Tomas2046 please explain your comments to prove you're not a bot.

@shlomi-noach shlomi-noach temporarily deployed to production/mysql_role=ghost_testing January 1, 2019 09:57 Inactive
@shlomi-noach
Copy link
Contributor Author

Updated underlying go-mysql library to get the fixes in go-mysql-org/go-mysql#332.

However, had to re-apply TIMESTAMP and DATETIME patches; go-mysql uses a new mechanism for parsing both old and new TIMESTAMP and DATETIME which seem to break gh-ost's tests whenever a non-UTC timezone is involved. I haven't been successful in finding out exactly why this happens, and so I've re-applied old temporal logic on top of the new changes.

@shlomi-noach shlomi-noach changed the title Testing DECIMAL datatype Fixed DECIMAL datatype Jan 2, 2019
@kwburgess kwburgess mentioned this pull request Jan 2, 2019
Open
@shlomi-noach shlomi-noach mentioned this pull request Jan 7, 2019
Closed
@shlomi-noach
Copy link
Contributor Author

tested in prod, looking good.

@shlomi-noach shlomi-noach merged commit d5c374a into master Jan 13, 2019
@shlomi-noach shlomi-noach deleted the test-decimal branch January 13, 2019 11:05
@shlomi-noach
Copy link
Contributor Author

I'll release this/next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shlomi-noach