Ensure mysql rows responses are closed #1132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures the rows-responses from the MySQL driver are closed by using a
defer rows.Close()
, in order to followdatabase/sql
best practicesAlso, these linters are introduced to ensure we don't have this problem again:
rowserrcheck
sqlclosecheck
This PR resolves these linter errors:
script/cibuild
returns with no formatting errors, build errors or unit test errors.