Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to customize the interval which the onStatus hook is called #1083

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

tknodell-recurly
Copy link
Contributor

A Pull Request should be associated with an Issue.

Related issue: #1082

Description

This PR adds a new flag hooks-status-interval which defaults to 60 seconds
Allows customization of how often the onStatus hook fires

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

Copy link
Contributor

@dm-2 dm-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tknodell-recurly, this looks good - we'll include this in the next release 👍

@dm-2 dm-2 added this to the v1.1.4 milestone Feb 7, 2022
@dm-2 dm-2 merged commit ebd5645 into github:master Feb 7, 2022
This was referenced Feb 7, 2022
@tknodell-recurly tknodell-recurly deleted the customize_status_hook_interval branch February 7, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants