Update filenames #578
Merged
Update filenames #578
+164
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arelia
reviewed
Nov 25, 2024
eslint.config.js
Outdated
| @@ -23,7 +23,7 @@ module.exports = [ | |||
| plugins: { | |||
| eslintPlugin, | |||
| importPlugin, | |||
| filenames, | |||
| filenamesPlugin: fixupPluginRules(filenames), | |||
There was a problem hiding this comment.
does it matter that it's not a string like 'i18n-text' on the next line?
There was a problem hiding this comment.
That should be okay - what I ended up doing was bringing in the filenames match regex rule into github. The filenames plugin is no longer supported and the compat utility was not working for our rule configuration.
arelia
approved these changes
Nov 25, 2024
arelia
reviewed
Nov 25, 2024
Co-authored-by: Arelia Jones <[email protected]>
arelia
reviewed
Nov 25, 2024
arelia
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filenames plugin is no longer maintained, and I was running into an issue that
fixupPluginRuleswould not fix for us using the compat utility in eslint v9. It needs theschema:https://github.com/github/eslint-plugin-github/pull/578/files#diff-b1acaab48d8385d990537662bf4fa3dd489b8974367f0628147c83977534feb4R13
Since the plugin is no longer being maintained, I decided to bring that particular regex rule into the
githubrules with the fix so that we no longer need to rely on thefilenameplugin.