Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tag of aws-actions/configure-aws-credentials #34809

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

shotarok
Copy link
Contributor

@shotarok shotarok commented Oct 2, 2024

Why:

A step copied from the doc failed because the sha1 didn't exist in the public repo anymore. I attached the error message from the failure job.

Download action repository 'aws-actions/configure-aws-credentials@d4e5f6a7b8c9d0e1f2a3b4c5d6e7f8a9b0c1d2e3' (SHA:d4e5f6a7b8c9d0e1f2a3b4c5d6e7f8a9b0c1d2e3)
Error: An action could not be found at the URI 'https://api.github.com/repos/aws-actions/configure-aws-credentials/tarball/d4e5f6a7b8c9d0e1f2a3b4c5d6e7f8a9b0c1d2e3' (4180:1E19A2:B9FF9:10BA2A:66FCD813)

What's being changed (if available, include any code snippets, screenshots, or gifs):

Update the tag of aws-actions/configure-aws-credentials on the doc.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Oct 2, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 2, 2024
@shotarok shotarok marked this pull request as ready for review October 2, 2024 05:35
…-your-deployments/configuring-openid-connect-in-amazon-web-services.md
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/security-for-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 2, 2024
@nguyenalex836
Copy link
Contributor

@shotarok Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added the needs SME This proposal needs review from a subject matter expert label Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836 nguyenalex836 added SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Oct 15, 2024
@nguyenalex836
Copy link
Contributor

@shotarok Thank you for your patience while our SME team reviewed! They approved of your changes ✨ I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Oct 15, 2024
Merged via the queue into github:main with commit 50085e6 Oct 15, 2024
46 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@shotarok shotarok deleted the update-action-tag branch October 15, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants