Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Minor tweaks to VS Code docs (query history + viewing results) #6523

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

shati-patel
Copy link
Contributor

I noticed a few areas where the docs were outdated:

  • In "Customizing settings", the default query history label was changed a while ago.
  • In "Viewing query results", the command for viewing SARIF has changed name and there's also an option to view CSV. (I've been deliberately vague about the command name for CSV, since it could be View Alerts or View Results, depending on how the query is structured. (Which should also help future-proof the docs if the command names change again!)
    I've also pulled this info about different views into a Note (in an attempt to declutter the actual steps), but other suggestions are welcome 😅
    image

PS: This can ship any time. I noticed these changes because of recent PRs in this general area (github/vscode-codeql#930 and github/vscode-codeql#929), but the docs change is valid now already!

@shati-patel shati-patel marked this pull request as ready for review August 19, 2021 19:49
mchammer01
mchammer01 previously approved these changes Aug 23, 2021
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shati-patel 👋🏻 - this LGTM 💖
I made a very minor suggestion (but feel free to ignore), and have a question about the order in which the different formats are listed (feel free to ignore too!)


#. Use the dropdown menu in the Results view to choose which results to display, and in what form to display them, such as a formatted alert message or a table of raw results. The available output forms are specified by the format of the query and the metadata. For more information, see ":ref:`CodeQL queries <codeql-queries>`."
Depending on the query, you can also choose different views such as CSV, :ref:`SARIF <sarif-output>`, or :ref:`DIL format <dil>`. For example, to view the DIL format, right-click a result and select **View DIL**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a logic in the order in which the formats are listed (Is it how they appear when you right-click a result?) or should we mention them alphabetically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! I've roughly listed them in order of "usefulness" 😀 People are probably most likely to want CSV, then SARIF, and (rarely) DIL. I think this also corresponds to the UI, but it depends on what's available, given the format of the query.

@shati-patel
Copy link
Contributor Author

Thank you for the review and the questions, @mchammer01! I took your suggestion, which dismissed the approval 🙃
Could you re-review when you have a moment? 😄

Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@shati-patel shati-patel merged commit 2a51abd into github:main Aug 23, 2021
@shati-patel shati-patel deleted the vscode-docs branch August 23, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants