Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Fix join-order problem in UserType::getADeclarationEntry #18588

Merged
merged 2 commits into from
Jan 24, 2025
Merged

C++: Fix join-order problem in UserType::getADeclarationEntry #18588

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c256d1
C++: Fix join-order problem in `UserType::getADeclarationEntry`
jketema Jan 24, 2025
2e33a42
C++: Apply review suggestion
jketema Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cpp/ql/lib/semmle/code/cpp/UserType.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,15 @@ class UserType extends Type, Declaration, NameQualifyingElement, AccessHolder, @
else result = this.getADeclarationLocation()
}

private TypeDeclarationEntry getADeclarationEntryBase() {
type_decls(underlyingElement(result), unresolveElement(this), _)
}
jketema marked this conversation as resolved.
Show resolved Hide resolved

override TypeDeclarationEntry getADeclarationEntry() {
if type_decls(_, unresolveElement(this), _)
then type_decls(underlyingElement(result), unresolveElement(this), _)
else exists(Class t | this.(Class).isConstructedFrom(t) and result = t.getADeclarationEntry())
pragma[only_bind_into](result) = pragma[only_bind_into](this).getADeclarationEntryBase()
or
not exists(this.getADeclarationEntryBase()) and
exists(Class t | this.(Class).isConstructedFrom(t) and result = t.getADeclarationEntry())
}

override Location getADeclarationLocation() { result = this.getADeclarationEntry().getLocation() }
Expand Down