Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant version checks #2696

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Remove redundant version checks #2696

merged 2 commits into from
Jan 16, 2025

Conversation

henrymercer
Copy link
Contributor

Delete redundant code after the deprecation of CodeQL v2.15.4 and earlier.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Remove version checks that always return true given the new minimum version of CodeQL.
@Copilot Copilot bot review requested due to automatic review settings January 15, 2025 18:03
@henrymercer henrymercer requested a review from a team as a code owner January 15, 2025 18:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 52 out of 67 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • .github/workflows/__config-export.yml: Evaluated as low risk
  • .github/workflows/__cpp-deptrace-enabled.yml: Evaluated as low risk
  • .github/workflows/__cpp-deptrace-enabled-on-macos.yml: Evaluated as low risk
  • .github/workflows/__cpp-deptrace-disabled.yml: Evaluated as low risk
  • .github/workflows/__config-input.yml: Evaluated as low risk
  • .github/workflows/__build-mode-none.yml: Evaluated as low risk
  • .github/workflows/__build-mode-rollback.yml: Evaluated as low risk
  • .github/workflows/__cleanup-db-cluster-dir.yml: Evaluated as low risk
  • .github/workflows/__autobuild-action.yml: Evaluated as low risk
  • .github/workflows/__autobuild-direct-tracing-with-working-dir.yml: Evaluated as low risk
  • .github/workflows/__build-mode-autobuild.yml: Evaluated as low risk
  • .github/workflows/__analyze-ref-input.yml: Evaluated as low risk
  • .github/workflows/__extractor-ram-threads.yml: Evaluated as low risk
  • .github/workflows/__extract-direct-to-toolcache.yml: Evaluated as low risk
  • .github/workflows/__autobuild-direct-tracing.yml: Evaluated as low risk

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@henrymercer henrymercer merged commit 7ae5fc3 into main Jan 16, 2025
267 checks passed
@henrymercer henrymercer deleted the henrymercer/delete-code branch January 16, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants