Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily include the Actions extractor with the Action #2582

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

dbartol
Copy link
Contributor

@dbartol dbartol commented Nov 7, 2024

This PR embeds the new experimental actions extractor to the CodeQL Action repo itself, and updates the init action to add that directory to --search-path if the actions language is enabled.

This is a hack to make the actions extractor available without it actually being in the bundle. This is needed for some internal testing over the next couple of weeks, after which the extractor will be in the bundle and we can remove this hack.

The extractor sources embedded here are just the current version copied directly from github/codeql.

I've already verified that this works correctly on a test repo with Advanced Setup.

@aeisenberg
Copy link
Contributor

This looks reasonable. Can you share a link to the run in the test repo?

Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good approach to me given the size of the Actions extractor.

The internal test run looks good, so approving.

@dbartol
Copy link
Contributor Author

dbartol commented Nov 8, 2024

@dbartol dbartol marked this pull request as ready for review November 8, 2024 16:13
@dbartol dbartol requested a review from a team as a code owner November 8, 2024 16:13
@dbartol dbartol merged commit f43e2e0 into main Nov 8, 2024
537 of 538 checks passed
@dbartol dbartol deleted the dbartol/actions-extractor branch November 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants