Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate add-snippets input. #2436

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

rvermeulen
Copy link
Contributor

@rvermeulen rvermeulen commented Aug 21, 2024

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

aeisenberg
aeisenberg previously approved these changes Aug 21, 2024
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding the link to the PR in the changelog. Also, can you create a deprecation issue in our private repository to track the deprecation?

CHANGELOG.md Outdated Show resolved Hide resolved
@rvermeulen rvermeulen marked this pull request as ready for review August 21, 2024 15:28
@rvermeulen rvermeulen requested a review from a team as a code owner August 21, 2024 15:28
aeisenberg
aeisenberg previously approved these changes Aug 21, 2024
CHANGELOG.md Outdated
@@ -24,6 +24,7 @@ No user facing changes.

- _Deprecation:_ Swift analysis on Ubuntu runner images is no longer supported. Please migrate to a macOS runner if this affects you. [#2403](https://github.com/github/codeql-action/pull/2403)
- Bump the minimum CodeQL bundle version to 2.13.5. [#2408](https://github.com/github/codeql-action/pull/2408)
- _Deprecation:_ The `add-snippets` input on the `analyze` Action is deprecated and will be removed in the first release in August 2025. [#2436](https://github.com/github/codeql-action/pull/2436)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intentionally add this to 3.26.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it to unreleased, must have gone wrong when I accepted a review suggestion 🤔. Let me move it back to unreleased.

@aeisenberg aeisenberg self-requested a review August 21, 2024 16:36
@rvermeulen rvermeulen merged commit ae01f80 into github:main Aug 21, 2024
304 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants