-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some more configuration errors #2237
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern with this one is that we have a bug in the action where we are inadvertently causing rate limits for the repository. I feel like this has happened in the past.
Is this error for an org/user or is it specific to the repository/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the time the rate limit hits are legitimate, so this creates a level of noise that means we have a bunch of false positive monitor pings or have to raise our thresholds and miss genuine failures. My recommendation is we avoid the possibility of a bug in the Action as part of our monitoring for significant changes in configuration errors, which is intended to capture these errors that are noisy, but have signal in large numbers.